Symfony Route annotation needs equal sign, not colon#3241
Merged
TomasVotruba merged 5 commits intorectorphp:masterfrom May 4, 2020
Merged
Symfony Route annotation needs equal sign, not colon#3241TomasVotruba merged 5 commits intorectorphp:masterfrom
TomasVotruba merged 5 commits intorectorphp:masterfrom
Conversation
Contributor
Author
|
@TomasVotruba I see you've refactored an important part, but this PR isn't merged yet. Are you planning to fix this issue, or can I help? |
Member
|
Help is needed, I have no idea how to fix it, and other issues are in my to-do list. |
Member
|
If the CI gets green, I'd be happy to merge it :) |
…s the underlying problem.
…fony-route-options
stephanvierkant
changed the title
Member
|
I'll try to solve this locally. Thanks for the PR! |
TomasVotruba
added a commit
that referenced
this pull request
Dec 22, 2022
rectorphp/rector-src@3c168f0 [CodingStyle] Skip new line /\r\n|\r|\n/i on ConsistentPregDelimiterRector (#3241)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #3225